Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate output matrices with salmon effective length #6

Closed
mdshw5 opened this issue Jan 13, 2021 · 2 comments
Closed

Annotate output matrices with salmon effective length #6

mdshw5 opened this issue Jan 13, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mdshw5
Copy link
Collaborator

mdshw5 commented Jan 13, 2021

DESeqDataSetFromTximport requires both counts and effective length. While PISCES uses effective length internally for DESeq2, it does not write out the values for use in downstream analysis.

@mdshw5 mdshw5 added the enhancement New feature or request label Jan 13, 2021
@mdshw5 mdshw5 self-assigned this Jan 13, 2021
@mdshw5
Copy link
Collaborator Author

mdshw5 commented Jun 25, 2021

@lucamarrocco - it looks like I already implemented this feature as part of 9f7ba0e, and I just need to do integration testing and push a new release.

@mdshw5 mdshw5 closed this as completed Sep 1, 2021
@mdshw5 mdshw5 reopened this Sep 2, 2021
@mdshw5
Copy link
Collaborator Author

mdshw5 commented Sep 2, 2021

@carloravagli I see that I should add the weighted gene-level effective length matrices as well. The tximport package provides summarizeToGene() for this purpose, which internally weights the lengths by abundance and takes an average:

https://github.com/mikelove/tximport/blob/b54bdbd2072c49043fc5834ca0500ecb214c6147/R/summarizeToGene.R#L90-L95

It can replace any problematic rows with a simple geometric mean as well. PISCES uses tximport internally so I will just write out the one extra gene-level length matrix.

mdshw5 added a commit that referenced this issue Sep 2, 2021
@mdshw5 mdshw5 closed this as completed in 56a5d9d Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant