Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ncfe 62 add init functionality #4

Merged
merged 15 commits into from
Nov 27, 2019
Merged

Feature/ncfe 62 add init functionality #4

merged 15 commits into from
Nov 27, 2019

Conversation

ankeris
Copy link
Contributor

@ankeris ankeris commented Nov 26, 2019 •
edited
Loading

@Epenance sorry for huge PR!

Features added:

  • /resources folder at the root of the folder (to copy all the files for CMS+SPA frontend setup). I took it out of src directory because it is a huge folder and webpack would require a lot of loaders to copy this directory.
  • Modularity improvements, e.g. create_file function added instead of repetitive logic.
  • Added helper flags (--help) and added flags like -d, --default to setup INIT faster

Epenance
Epenance approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@Epenance Epenance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G2M

src/@utils/index.ts Outdated

export const showcase_opts = (features: FeatureList) => {
console.log('');
console.log('Features: ');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use newline? \n

@ankeris ankeris merged commit c8b3de7 into master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Epenance Epenance Epenance approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankeris @Epenance