lang: Load scripts after theUILang has loaded #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scripts which depend on theUILang must be executed after theUILang has loaded. Unfortunately, in order to fix Novik#2543, the time the browser fetches these scripts is now also delayed. Preferably, scripts should not depend on theUILang during startup. Fixes Novik#2543
|
@TrimmingFool Is there a simpler solution here? This looks like a CSS pseudoclass issue with Safari. It might be possible to do a one liner solution here with jQuery. https://stackoverflow.com/questions/1293369/using-the-last-child-selector For instance: |
|
@TrimmingFool Nevermind, I tested alternative solutions with no success. I'll merge this PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stickz #2543 (comment) Yeah, it seems, this not working for Safari.
Scripts which depend on theUILang must be executed after theUILang has loaded.
Unfortunately, in order to fix #2543, the time the browser fetches these scripts is now also delayed.
Preferably, scripts should not depend on theUILang during startup.
Fixes #2543
I did not test this with Safari but with Firefox, Chromium and Epiphany.