Fix out of bounds and sort issue

Was a bug when switching between item/tab view where out of bounds errors could occur.

Fix refresh sorting issue on view change

Make warnings more explicit and 'safer'.  This by itself would have fixed crashes caused by calling rowCount in
old assertion with out-of-date parent.

src/items_model.cpp

@@ -184,17 +184,18 @@ QModelIndex ItemsModel::parent(const QModelIndex &index) const {
 }
 
 QModelIndex ItemsModel::index(int row, int column, const QModelIndex &parent) const {
-    // bucket
-    if (row < 0 || row >= rowCount(parent) || column < 0 || column >= columnCount(parent)) {
-        QLOG_WARN() << "Unexpected Index request: row(" << row << ") maxrow(" << rowCount(parent)
-                       << ") col(" << column << ") maxcol(" << columnCount(parent);
-        return QModelIndex();
-    }
-
     if (parent.isValid()) {
+        if (parent.row() >= (signed)search_.buckets().size()) {
+            QLOG_WARN() << "Should not happen: Index request parent contains invalid row";
+            return QModelIndex();
+        }
         // item, we pass parent's (bucket's) row through ID parameter
         return createIndex(row, column, static_cast<quintptr>(parent.row() + 1));
     } else {
+        if (row >= (signed)search_.buckets().size()) {
+            QLOG_WARN() << "Index request asking for invalid row";
+            return QModelIndex();
+        }
         return createIndex(row, column, static_cast<quintptr>(0));
     }
 }

src/search.cpp

@@ -181,7 +181,8 @@ void Search::SetViewMode(ViewMode mode)
 
         current_mode_ = mode;
         // Force immediate view update
-        view_->doItemsLayout();
+        view_->reset();
+        model_->SetSorted(false);
         model_->sort();
 
         if (mode == ByTab)