Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change: Refine overlay trigger #69

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Breaking change: Refine overlay trigger #69

merged 2 commits into from
Mar 28, 2023

Conversation

Nowely
Copy link
Owner

@Nowely Nowely commented Mar 28, 2023 •
edited
Loading

  • Add the trigger prop for overlay
  • Change default behavior for the trigger from selectionChange to change
  • Rename the Trigger type to OverlayMatch
  • Rename the AnnotatedMark type to MarkMatch
  • Rename the prop trigger to match by useOverlay

@vercel
Copy link

vercel bot commented Mar 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
marked-input ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 6:39PM (UTC)

@Nowely Nowely changed the title Breaking change: Change behaviour Breaking change: Refine overlay trigger Mar 28, 2023
@Nowely Nowely merged commit d0c1a5b into next Mar 28, 2023
@Nowely Nowely deleted the change_behaviour branch March 28, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nowely