Swift 4: Make SyncSinkTarget a class

... fix concurrent memory access issue.
NozeIO · Mar 12, 2018 · 681e129 · 681e129
1 parent d8bf4e3
commit 681e129
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/Sources/streams/adaptors/SinkTarget.swift b/Sources/streams/adaptors/SinkTarget.swift
@@ -16,7 +16,7 @@ public protocol SinkType { // 2beta4 has no SinkType anymore
   mutating func put(_ x: Self.Element)
 }
 
-public struct SyncSinkTarget<S: SinkType> : GWritableTargetType {
+public class SyncSinkTarget<S: SinkType> : GWritableTargetType {
 
   public static var defaultHighWaterMark : Int { return 1 }
 
@@ -28,7 +28,7 @@ public struct SyncSinkTarget<S: SinkType> : GWritableTargetType {
     self.target = target
   }
 
-  private mutating func _writev(chunks : [ [ S.Element ] ]) -> Int {
+  private func _writev(chunks : [ [ S.Element ] ]) -> Int {
     var count = 0
 
     for bucket in chunks {
@@ -40,9 +40,9 @@ public struct SyncSinkTarget<S: SinkType> : GWritableTargetType {
     return count
   }
 
-  public mutating func writev(queue q : DispatchQueue,
-                              chunks  : [ [ S.Element ] ],
-                              yield   : @escaping ( Error?, Int ) -> Void)
+  public func writev(queue q : DispatchQueue,
+                     chunks  : [ [ S.Element ] ],
+                     yield   : @escaping ( Error?, Int ) -> Void)
   {
     let count = _writev(chunks: chunks)
     yield(nil, count)

diff --git a/Tests/streamsTests/BasicTests.swift b/Tests/streamsTests/BasicTests.swift
@@ -29,7 +29,7 @@ class NozeIOBasicTests: XCTestCase {
 
   func testSinkTarget() {
     let Q      = core.Q
-    var target = SyncSinkTarget<NumberPrinter>(NumberPrinter())
+    let target = SyncSinkTarget<NumberPrinter>(NumberPrinter())
 
     target.writev(queue: Q, chunks: [ [ 10 ] ] ) { _, writeCount in
       print("   * wrote: \(writeCount)")