Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.env should not be part of git commit set #70

Open
dmd opened this issue Apr 8, 2021 · 1 comment
Open

.env should not be part of git commit set #70

dmd opened this issue Apr 8, 2021 · 1 comment

Comments

@dmd
Copy link
Contributor

dmd commented Apr 8, 2021

Best practice is that .env should never be part of a repository. Doing so makes merging upstream changes more difficult and can lead to accidentally committing sensitive data (like postgres and smtp passwords) to a repository.

Instead, create an example file .env-dist which should be copied by the user.

.env should be in .gitignore.
dmd added a commit to dmd/xnat-docker-compose that referenced this issue Apr 8, 2021
@dmd
use .env-dist as an example. closes NrgXnat#70
3d18425
@dmd
Copy link
Contributor Author

dmd commented Apr 8, 2021

The PR I submitted fails testing, but that is correct - the testing needs to change to copy .env-dist to .env.

kelseym added a commit that referenced this issue May 20, 2021
@kelseym
Updated XNAT references to v1.8.2. Addressed #70 by moving .env file …
2ac742d 
…to default.env. This matches the pattern used on the dependency-mgmt branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmd