Enable -Werror for compiler build

NthPortal · Oct 23, 2020 · 0343756 · 0343756
1 parent c9b79e7
commit 0343756
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/build.sbt b/build.sbt
@@ -800,6 +800,7 @@ lazy val compiler = configureAsSubproject(project)
   .settings(generateBuildCharacterFileSettings)
   .settings(Osgi.settings)
   .settings(AutomaticModuleName.settings("scala.tools.nsc"))
+  .settings(fatalWarningsSettings)
   .settings(
     name := "scala-compiler",
     description := "Scala Compiler",

diff --git a/src/compiler/scala/tools/nsc/typechecker/Implicits.scala b/src/compiler/scala/tools/nsc/typechecker/Implicits.scala
@@ -483,7 +483,7 @@ trait Implicits {
     private def dominates(dtor: Type, dted: Type): Boolean = {
       @annotation.tailrec def sumComplexity(acc: Int, xs: List[Type]): Int = xs match {
         case h :: t => sumComplexity(acc + complexity(h), t)
-        case _: Nil.type => acc
+        case _      => acc
       }
 
       def complexity(tp: Type): Int = tp.dealias match {

diff --git a/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala b/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala
@@ -1146,7 +1146,7 @@ abstract class RefChecks extends Transform {
       }
       val receiver = underlyingClass(qual.tpe)
       val actual   = underlyingClass(other.tpe)
-      def typesString = normalizeAll(qual.tpe.widen)+" and "+normalizeAll(other.tpe.widen)
+      def typesString = s"${normalizeAll(qual.tpe.widen)} and ${normalizeAll(other.tpe.widen)}"
       def nonSensiblyEquals() = {
         refchecksWarning(pos, s"comparing values of types $typesString using `${name.decode}` is unsafe due to cooperative equality; use `==` instead", WarningCategory.OtherNonCooperativeEquals)
       }