This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Expose container style (necessary for IE support) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thanks for your contribution. I'm going to review this and other PRs a and merge them. |
|
Cool thanks @topicus - much appreciated |
topicus
added a commit
that referenced
this pull request
Jan 12, 2016
Expose container style (necessary for IE support)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @topicus,
It seems that Microsoft IE9/10/11 ignores svg height attribute. So the only way to set height for charts on IE is to set the height on the nv-chart container div via css.
But currently it is not possible to do this dynamically.
Such behaviour is really important for a project I am working on, where we need to be able to set the height of charts dynamically and (sadly) support IE.
So...
This pull request exposes the nv-chart container's style attribute. It tries to follow the style used elsewhere in this project. Hope this is ok. Anyways let me know what you think.
Thanks!
Ben