Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new msbuild property to exclude build output for specific tfms during pack task #10396

Closed
Anipik opened this issue Dec 18, 2020 · 8 comments · Fixed by NuGet/NuGet.Client#3810

Comments

@Anipik
Copy link

Anipik commented Dec 18, 2020

Nuget currently provides a msbuild called IncludeBuildOutput to disable including the build output for all tfms.
Nuget provides this kind of feature for other targets like _GetFrameworksWithSuppressedDependencies which run during the pack command.
It will enable the scenario where developer wants to exclude a certain kind of build output for a specific tfm.

cc @ViktorHofer @nkolev92 @ericstj @safern

@ViktorHofer
Copy link

Or just respect the existing property in inner builds as well?

@Anipik
Copy link
Author

Anipik commented Dec 18, 2020

Or just respect the existing property in inner builds as well?

yep i thought that as well, just added a new one to just start the discussion. moving the existing property to innerbuilds will be optimal

@ViktorHofer
Copy link

Agreed, this is a good way to start a discussion. What confused me is that you already opened a PR with a new property name. The problem with a new property is that even if it will be documented (which it should be), it would cause confusion about the differences between the existing and the new one.

@nkolev92
Copy link
Member

I think reusing the existing property is better than the new one.
Thinking through it, I don't think there should be any concerns with compat with that either.

@nkolev92
Copy link
Member

cc @zkat when they're back :)

@Anipik
Copy link
Author

Anipik commented Dec 21, 2020

Updated the pr

@erdembayar
Copy link
Contributor

erdembayar commented Jan 25, 2021

@Anipik
This PR introduced regression bug issue#10462. So we're reverting the merge.
Can you check what was the problem and rectify it and create new merge PR request?

@erdembayar
Copy link
Contributor

erdembayar commented Jan 26, 2021

It seems false alert here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants