-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a new msbuild property to exclude build output for specific tfms during pack task #10396
Comments
Or just respect the existing property in inner builds as well? |
yep i thought that as well, just added a new one to just start the discussion. moving the existing property to innerbuilds will be optimal |
Agreed, this is a good way to start a discussion. What confused me is that you already opened a PR with a new property name. The problem with a new property is that even if it will be documented (which it should be), it would cause confusion about the differences between the existing and the new one. |
I think reusing the existing property is better than the new one. |
cc @zkat when they're back :) |
Updated the pr |
@Anipik |
It seems false alert here |
Nuget currently provides a msbuild called IncludeBuildOutput to disable including the build output for all tfms.
Nuget provides this kind of feature for other targets like
_GetFrameworksWithSuppressedDependencies
which run during the pack command.It will enable the scenario where developer wants to exclude a certain kind of build output for a specific tfm.
cc @ViktorHofer @nkolev92 @ericstj @safern
The text was updated successfully, but these errors were encountered: