Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deprecation Links in Details page in PM UI #10996

Closed
dominoFire opened this issue Jul 6, 2021 · 4 comments · Fixed by NuGet/NuGet.Client#4144
Closed

Add Deprecation Links in Details page in PM UI #10996

dominoFire opened this issue Jul 6, 2021 · 4 comments · Fixed by NuGet/NuGet.Client#4144

Comments

@dominoFire
Copy link
Contributor

Add two new deprecation links in details Page in PM UI when a package is deprecated.

  • More Info Link
  • Alternate package Link
@skofman1
Copy link
Contributor

skofman1 commented Sep 7, 2021

Hi @dominoFire , looked at the cool demo of the feature (this is so useful!), and I have a minor suggestion.

For packages where the version of the 'Alternative package' isn't specified, right now we show 'Azure.Storage.Blobs >= 0.0.0'. How about:

  1. Just the package name with no version
  2. Showing 'Azure.Storage.Blobs any version'

What do you think? Again, it's minor but the current UX is a bit confusing.

image

//cc @aortiz-msft

@aortiz-msft
Copy link
Contributor

@chgill-MSFT ^

@dominoFire
Copy link
Contributor Author

@skofman1 @aortiz-msft @chgill-MSFT Thanks for the follow-up. We have a current discussion in the following issue:

#8795

I think we should match the experience in nuget.org

@chrisraygill
Copy link
Contributor

chrisraygill commented Sep 9, 2021

@dominoFire IMO we should just open the package details window to the default version given their search preferences.

If they have Include prerelease enabled, then show the latest stable/prerelease version. If they have Include prerelease disabled, then show the latest stable version.

This is already how browse works in the PMUI today in normal search scenarios. NuGet.org works a little differently, but I think somewhat incidentally. On NuGet.org the alternate package deprecation link goes to nuget.org/packages/<packageID>/ with no version specified which goes to the latest stable version. On NuGet.org, there's nowhere to specify a preference for prerelease or stable versions on the package details page - only in search.

TL;DR

Let's do what's most natural to the PMUI already which isn't exactly what NuGet.org does.

In the case of afine >= 0.0.0 today, instead:

Don't show any version - open the linked package to the latest stable or latest including prerelease depending on if "Include prerelease" is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants