Make dotnet package verification env var value comparison case insensitive

[erdembayar]

NuGet Product Used

dotnet.exe

Product Version

n/a

Worked before?

No response

Impact

No response

Repro Steps & Context

You are comparing the env var and bool true value, while only converting the latter to uppercase.

Console.WriteLine(IsEnabled(null));
Console.WriteLine(IsEnabled("true"));
Console.WriteLine(IsEnabled("TRUE"));

static object IsEnabled(string signVerifyEnvVariable)
{
    if (!string.IsNullOrEmpty(signVerifyEnvVariable))
    {
        if (signVerifyEnvVariable.Equals(bool.TrueString.ToUpperInvariant(), StringComparison.Ordinal))
        {
            return true;
        }

        // other values are unsupported
        return false;
    }
    return false;
}

This would print:

False
False
True

which is incorrect and should be:

False
True
True

instead.

Verbose Logs

No response

[zivkan]

Why not use StringComparison.OrdinalIgnoreCase?

ToUpperInvarient() will definitely cause a memory allocation, whereas passing the strings we already have into a different string comparer might not.

[zivkan]

@erdembayar the title of this issue does not match the implementation of the PR that closed it.