Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages.config restore does not retry on 5xx status codes from V2 sources #1217

Closed
emgarten opened this issue Aug 19, 2015 · 2 comments
Closed

Packages.config restore does not retry on 5xx status codes from V2 sources #1217

emgarten opened this issue Aug 19, 2015 · 2 comments
Labels
Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug
Milestone
3.5 Beta

Comments

@emgarten
Copy link
Member

Restoring a packages.config project from V2 will fail if a 503 status code is returned by the server during a call to FindPackagesById or the package download endpoint.

NuGet.Core should retry in these scenarios.

RestoreRetry_PackagesConfigRetryOnFailingV2Source should be re-enabled after fixing this.
@yishaigalatzer yishaigalatzer added this to the 3.3.0-commandline milestone Aug 21, 2015
@yishaigalatzer yishaigalatzer added the Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. label Nov 18, 2015
@emgarten
Copy link
Member Author

This is fixed now that all V2 http requests are made through HttpSource and the retry handler.

@joelverhagen
Copy link
Member

Verified fixed with 3.5.0-beta (build 3.5.0.1249)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug
Projects
None yet
Milestone
3.5 Beta
Development

No branches or pull requests
3 participants
@joelverhagen @yishaigalatzer @emgarten