New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages.config restore does not retry on 5xx status codes from V2 sources #1217

Closed
emgarten opened this Issue Aug 19, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@emgarten
Collaborator

emgarten commented Aug 19, 2015

Restoring a packages.config project from V2 will fail if a 503 status code is returned by the server during a call to FindPackagesById or the package download endpoint.

NuGet.Core should retry in these scenarios.

RestoreRetry_PackagesConfigRetryOnFailingV2Source should be re-enabled after fixing this.

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Feb 29, 2016

Collaborator

This is fixed now that all V2 http requests are made through HttpSource and the retry handler.

Collaborator

emgarten commented Feb 29, 2016

This is fixed now that all V2 http requests are made through HttpSource and the retry handler.

@emgarten emgarten closed this Feb 29, 2016

@joelverhagen

This comment has been minimized.

Show comment
Hide comment
@joelverhagen

joelverhagen May 11, 2016

Member

Verified fixed with 3.5.0-beta (build 3.5.0.1249)

Member

joelverhagen commented May 11, 2016

Verified fixed with 3.5.0-beta (build 3.5.0.1249)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment