Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet.Build.Tasks.Console should roll forward to newer runtimes #12528

Closed
dfederm opened this issue Apr 5, 2023 · 1 comment · Fixed by NuGet/NuGet.Client#5125
Closed

NuGet.Build.Tasks.Console should roll forward to newer runtimes #12528

dfederm opened this issue Apr 5, 2023 · 1 comment · Fixed by NuGet/NuGet.Client#5125
Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Partner:1ES Priority:2 Issues for the current backlog. Type:Bug
Milestone

Comments

@dfederm
Copy link

dfederm commented Apr 5, 2023

NuGet Product Used

Other/NA

Product Version

6.5.0

Worked before?

N/A

Impact

It's more difficult to complete my work

Repro Steps & Context

The NuGet.Build.Tasks.Console package contains a runnable app that is built against .NET 5. When this component is inserted into the .NET SDK, the insertion process generates a runtimeconfig that re-targets the application against whatever version of the runtime is being built.

This means that the NuGet.Build.Tasks.Console application can't be used in a custom way without regenerating the runtimeconfig. If the existing runtimeconfig had rollFoward: latestMajor then it would work in all runtimes greater than or equal to .NET 5.

{
  "runtimeOptions": {
    "tfm": "net5.0",
    "rollFoward": "latestMajor",
    "framework": {
      "name": "Microsoft.NETCore.App",
      "version": "5.0.0"
    },
    "configProperties": {
      "System.GC.Server": true,
      "System.Reflection.Metadata.MetadataUpdater.IsSupported": false
    }
  }
}

Verbose Logs

No response

@dfederm
Copy link
Author

dfederm commented Apr 6, 2023

As per #5125, adding RollForward should also address this issue in a different way.

@jeffkl jeffkl changed the title NuGet.Build.Tasks.Console does not contain net7.0 version NuGet.Build.Tasks.Console should roll forward to newer runtimes Apr 6, 2023
@jeffkl jeffkl added Priority:2 Issues for the current backlog. Partner:1ES Area:RestoreStaticGraph Issues related to the Static Graph restore and removed Triage:Untriaged labels Apr 6, 2023
@nkolev92 nkolev92 added this to the 6.7 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Partner:1ES Priority:2 Issues for the current backlog. Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants