Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RollForward to NuGet.Build.Tasks.Console #5125

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

dfederm
Copy link
Contributor

@dfederm dfederm commented Apr 6, 2023

Bug

Fixes: #12528

Regression? Last working version: N/A

Description

Currently, NuGet.Build.Tasks.Console contains an executable which targets the .NET 5 runtime, so to use the package either the .NET 5 runtime (an EOL runtime) needs to be installed, or as the insertion process does the application is retargetted on the fly.

This change adds rollforward to the runtimeconfig so that the application is runnable on newer versions of the runtime. In theory, this makes the retargetting unnecessary, but I'm not proposing that process changes for now.

Note: for context, NuGet.Build.Tasks.Console is either told where to find dotnet explicitly, or it just looks two directories up for it. So this change just allows either of those to be newer runtimes and not just crash.

Additionally, the NuGet.Build.Tasks.Console package is used in the MSBuild boottrapper, which is a fundamental part of MSBuild's CI process (it builds, then uses the output to build itself again with the new bits). So this would bring that scenario a bit more inline with how it actually works in the SDK.

FYI @jeffkl with whom I discussed offline

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@dfederm dfederm requested a review from a team as a code owner April 6, 2023 15:40
@ghost ghost added the Community PRs created by someone not in the NuGet team label Apr 6, 2023
@jeffkl jeffkl self-assigned this Apr 6, 2023
@jeffkl jeffkl merged commit c103f32 into NuGet:dev Apr 7, 2023
@dfederm dfederm deleted the rollfwd branch April 7, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuGet.Build.Tasks.Console should roll forward to newer runtimes
3 participants