New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yellow 'CACHE' bar shown in Visual Studio on add operations from PM UI #13407
Comments
I downloaded BaGet but wasn't able to repro. Can you give some details on how you have BaGet setup? |
This isn’t dependent on an BaGet. I get this cache bar all the time |
Adding the content from e-mail here:
Some guesses were because that's the first time that source is being accessed, details on PackageReference and requiring sources to always be available - https://learn.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#packagereference-and-sources, which could due to the source mapping existing. We're yet unable to confirm the repro. Assigning to current hotseat @kartheekp-ms to investigate more. |
Team Triage: A few ideas:
|
@kartheekp-ms Please continue the investigation so we can confirm our assumptions. |
I am able to reproduce the yellow bar in Visual Studio by following below steps.
Actual: Upon debugging, I found the exact line of code and call stack that resulted in this yellow bar. Looking at the commit history it looks like commit has introduced a new method to run NuGet audit while enabling vulnerability checking for packages.config projects during commandline restore. There have been some changes to the same file in NuGet/NuGet.Client#5646 PR. These changes were pointing to the packages.config style projects but not sure yet why this change impacts package reference style projects also. NuGet Call Stack Trace
|
That matches @jgonz120's summary that I copied here in #13407 (comment).
The PackageReference one has been implemented for some time in https://github.com/NuGet/NuGet.Client/blob/12d5c661b77d4933f82a293008c0d56d1d6ce32b/src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/AuditUtility.cs#L334. Runs the same logic, which is what Tim's scenario is hitting. Sounds to me like we're reaching the same conclusions, and the slowdown is due to a slow responding source. I think #13407 (comment) still makes sense for improvements. Thanks for the analysis @kartheekp-ms |
NuGet Product Used
Visual Studio Package Management UI
Product Version
17.11 preview
Worked before?
Wasn't their prior
Impact
It bothers me. A fix would be nice
Repro Steps & Context
Add a package and see a CACHE goldbar above the PM UI
Verbose Logs
No response
The text was updated successfully, but these errors were encountered: