installing package from a local source that doesn't exist throws a bogus message

[yishaigalatzer]

Run the following command from Power Shell, of course make sure the folder c:\temp\data does not exist on your machine

PM> install-package Rules -source c:\temp\data
install-package : Unable to find package 'Rules'
At line:1 char:1
+ install-package Rules -source c:\temp\data
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand

The error says Unable to find package 'Rules' instead of cannot find the folder (or a mix of the two)

[mishra14]

@rohit21agrawal @yishaigalatzer @harikmenon @rrelyea

Please let me know if this looks fine?

Case 1 - invalid local path

PM> install-package Rules -source c:\temp\data
install-package : Unable to find package 'Rules' at source 'c:\temp\data'. Source not found.
At line:1 char:1
+ install-package Rules -source c:\temp\data
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand
Time Elapsed: 00:00:00.0579984

Case 2 - Invalid http path that does not contain the package

PM> install-package Rules -source http://example.com
install-package : An error occurred while retrieving package metadata for 'Rules' from source 'http://example.com'.
  The V2 feed at 'http://example.com/FindPackagesById()?id='Rules'' returned an unexpected status code '404 Not Found'.
At line:1 char:1
+ install-package Rules -source http://example.com
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand

Case 3 - Random String as path

PM> install-package Rules -source random-string
install-package : Unsupported type of source  'random-string'. Please provide an http or local source.
At line:1 char:1
+ install-package Rules -source random-string
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand
Time Elapsed: 00:00:00.0547044

[rohit21agrawal]

a random string can be the name of a source in the nuget.config file

[mishra14]

Yes. As we discussed offline, I will be removing the check for that. Thanks!

[mishra14]

@yishaigalatzer @harikmenon @rrelyea

Please let me know if this looks fine?

I have edited them, based on feedback from @rohit21agrawal .

Case 1 - invalid local path

PM> install-package Rules -source c:\temp\data

install-package : Unable to find package 'Rules' at source 'c:\temp\data'. Source not found.
At line:1 char:1
+ install-package Rules -source c:\temp\data
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], InvalidOperationException
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand

Case 2 - Valid http path that does not contain the package

PM> install-package Rules -source http://example.com
install-package : An error occurred while retrieving package metadata for 'Rules' from source 'http://example.com'.
  The V2 feed at 'http://example.com/FindPackagesById()?id='Rules'' returned an unexpected status code '404 Not Found'.
At line:1 char:1
+ install-package Rules -source http://example.com
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand

Case 3 - Random String as path

PM> install-package Rules -source nuget.random
install-package : Unsupported type of source  'nuget.random'. Please provide an http or local source.
At line:1 char:1
+ install-package Rules -source nuget.random
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], InvalidOperationException
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand

Case 4 - Known source

PM> install-package Rules -source nuget.org
install-package : Unable to find package 'Rules'
At line:1 char:1
+ install-package Rules -source nuget.org
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand

[harikmenon]

[rrelyea]

Case 2 seems confusing. Why do we talk about package metadata?

[alpaix]

When the implementation PR is pushed we need to add end-to-end tests for each of the cases.

[mishra14]

@harikmenon : Realized that we cant have different error message for a random string, since its treated as a local relative string ( like a local folder name!). So the case 3 would be updated to the following -

Update Case 3 -

PM> install-package Rules -source nuget.random
install-package : Unable to find package 'Rules' at source 'nuget.random'. Source not found.
At line:1 char:1
+ install-package Rules -source nuget.random
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], PackageSourceException
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand

Let me know your thoughts or if this is fine?

cc : @rohit21agrawal @rrelyea @yishaigalatzer

[harikmenon]

Sounds good to me.

[mishra14]

@harikmenon : Had an offline talk with @rrelyea about the complexity of the error message in Case 2.

I will update that to the following, simpler error message -

Update Case 2 -

install-package : Unable to find package 'Rules' at source 'http://example.com'.
At line:1 char:1
+ install-package Rules -source http://example.com
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand

Let me know if this looks fine?

cc : @rohit21agrawal @yishaigalatzer

[harikmenon]

[mishra14]

Original issue commits : NuGet/NuGet.Client@0f83bee NuGet/NuGet.Client@779f2bb

Improved Case 2 error message commit : NuGet/NuGet.Client@370687d

End to End test cases commit : NuGet/NuGet.Client@018ebd6