Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frameworks within the portable profile are not allowed to have profiles themselves #1869

Closed
maartenba opened this issue Dec 23, 2015 · 1 comment
Closed

Frameworks within the portable profile are not allowed to have profiles themselves #1869

maartenba opened this issue Dec 23, 2015 · 1 comment
Assignees
@maartenba
Labels
Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug
Milestone
3.4 RTM

Comments

@maartenba
Copy link
Contributor

Relates to NuGet/NuGetGallery#2822 - Frameworks within the portable profile should not be allowed to have profiles themselves.

Arrange:

Act:

  • NuGet.Packaging.PackageReader.GetSupportedFrameworks() on the given package

Assert:

  • Result should not contain an entry for the invalid framework "portable-net+win+wpa+wp+sl+net-cf+netmf+MonoAndroid+MonoTouch+Xamarin.iOS"

Actual:

  • Result contains an entry for the invalid framework "portable-net+win+wpa+wp+sl+net-cf+netmf+MonoAndroid+MonoTouch+Xamarin.iOS"

This string is not supported by our framework name parser because of multiple hyphens ("portable-" and "net-cf").
@maartenba maartenba mentioned this issue Dec 23, 2015
Merged
@yishaigalatzer yishaigalatzer added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug labels Dec 26, 2015
@yishaigalatzer yishaigalatzer added this to the 3.4 milestone Dec 26, 2015
@maartenba maartenba mentioned this issue Dec 28, 2015
Closed
@maartenba
Copy link
Contributor Author

Created PR. NuGet/NuGet.Client#165

@yishaigalatzer yishaigalatzer modified the milestones: 3.4 Beta, 3.4 RTM Feb 25, 2016
@yishaigalatzer yishaigalatzer modified the milestones: 3.4 RTM, 3.4 RTM - Triage Mar 11, 2016
@yishaigalatzer yishaigalatzer modified the milestones: 3.4 RTM, 3.4 RTM - Triage Mar 11, 2016
@joelverhagen joelverhagen mentioned this issue May 6, 2016
Closed
@brandonh-msft brandonh-msft mentioned this issue Jul 13, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maartenba maartenba

Labels
Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug
Projects
None yet
Milestone
3.4 RTM
Development

No branches or pull requests
2 participants
@maartenba @yishaigalatzer