Frameworks within the portable profile are not allowed to have profiles themselves #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -497,5 +497,20 @@ public void PackageReader_SupportedFrameworks() | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void PackageReader_SupportedFrameworksForInvalidPortableFrameworkThrows() | |||
There was a problem hiding this comment.
In theory this test is not required, but since NuGet/Home#1869 mentions a broken package this test was added to test front to back.
|
looks good to me. @emgarten what do you think? |
|
Looks good |
|
So I can just merge? |
|
Is this change in? |
|
No, was waiting for a "yes please merge" :-) |
|
It looks good to me. //cc @yishaigalatzer |
|
Let's get this merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NuGet/Home#1869
Note that current 3.3 does not throw when such invalid framework is encountered. Instead, it parses the framework into:
.NETPortable,Version=v0.0,Profile=net+win+wpa+wp+sl+net-cf+netmf+MonoAndroid+MonoTouch+Xamarin.iOSThis PR changes the behaviour and will throw
FrameworkExceptionin these cases.