Failing to authenticate package source (3 times) is blocked forever

[alpaix]

Problem
In case of authenticated private source configured user prompted to provide credentials 3 times. If it fails user never gets asked again. To recover from this state one is required to restart Visual Studio.

Solution

1.   If the user cancels – We don’t retry
   

2.   In a new operation (install/update/restore) we ask for the credentials again
   

[pspill]

[pspill]

Attached screenshots of the behavior after: 1) perform any NuGet operation that needs to authenticate with the MyGet feed, 2) cancel the login dialog 3 times, and 3) perform any other operation.

At this point mos tof the operations will report an error, but it won't be clear to the user that they need to close and reopen VS to unblock. Note that for the NuGet Package Manager \ Installed UI, the Loading... throbber will permanently spin.

[alpaix]

For 3.4 we can simply consider changing the error message and make it clear for a user he needs to restart application, or disable/enable the source. Does it make sense?

[alpaix]

@pspill Infinite spinning issue has been resolved in NuGet/NuGet.Client#402

[yishaigalatzer]

@alpaix I believe there is a duplicate on you for this issue, can you please find and close

[alpaix]

Fixed by NuGet/NuGet.Client#388.