New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to authenticate package source (3 times) is blocked forever #2362

Closed
alpaix opened this Issue Mar 18, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@alpaix
Collaborator

alpaix commented Mar 18, 2016

Problem
In case of authenticated private source configured user prompted to provide credentials 3 times. If it fails user never gets asked again. To recover from this state one is required to restart Visual Studio.

Solution

  1.   If the user cancels – We don’t retry
    
  2.   In a new operation (install/update/restore) we ask for the credentials again
    
@pspill

This comment has been minimized.

Show comment
Hide comment
@pspill

pspill commented Mar 21, 2016

restorebutton_after3cancelledlogin
installed_after3cancelledlogin
build_after3cancelledlogin
browse_after3cancelledlogin

@pspill

This comment has been minimized.

Show comment
Hide comment
@pspill

pspill Mar 21, 2016

Attached screenshots of the behavior after: 1) perform any NuGet operation that needs to authenticate with the MyGet feed, 2) cancel the login dialog 3 times, and 3) perform any other operation.

At this point mos tof the operations will report an error, but it won't be clear to the user that they need to close and reopen VS to unblock. Note that for the NuGet Package Manager \ Installed UI, the Loading... throbber will permanently spin.

pspill commented Mar 21, 2016

Attached screenshots of the behavior after: 1) perform any NuGet operation that needs to authenticate with the MyGet feed, 2) cancel the login dialog 3 times, and 3) perform any other operation.

At this point mos tof the operations will report an error, but it won't be clear to the user that they need to close and reopen VS to unblock. Note that for the NuGet Package Manager \ Installed UI, the Loading... throbber will permanently spin.

@alpaix

This comment has been minimized.

Show comment
Hide comment
@alpaix

alpaix Mar 21, 2016

Collaborator

For 3.4 we can simply consider changing the error message and make it clear for a user he needs to restart application, or disable/enable the source. Does it make sense?

Collaborator

alpaix commented Mar 21, 2016

For 3.4 we can simply consider changing the error message and make it clear for a user he needs to restart application, or disable/enable the source. Does it make sense?

@alpaix

This comment has been minimized.

Show comment
Hide comment
@alpaix

alpaix Mar 21, 2016

Collaborator

@pspill Infinite spinning issue has been resolved in NuGet/NuGet.Client#402

Collaborator

alpaix commented Mar 21, 2016

@pspill Infinite spinning issue has been resolved in NuGet/NuGet.Client#402

@yishaigalatzer

This comment has been minimized.

Show comment
Hide comment
@yishaigalatzer

yishaigalatzer Mar 23, 2016

@alpaix I believe there is a duplicate on you for this issue, can you please find and close

yishaigalatzer commented Mar 23, 2016

@alpaix I believe there is a duplicate on you for this issue, can you please find and close

@yishaigalatzer yishaigalatzer modified the milestones: 3.5 Beta, 3.5 RC Apr 8, 2016

@alpaix

This comment has been minimized.

Show comment
Hide comment
@alpaix

alpaix Apr 28, 2016

Collaborator
Collaborator

alpaix commented Apr 28, 2016

@alpaix alpaix closed this Apr 28, 2016

@alpaix alpaix modified the milestones: 3.5 Beta2, 3.5 RC Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment