-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuGet update through package manager removes properties from the project.json #2888
Comments
Are you using 3.5-beta of vsix? |
No, was using 3.4.3. |
I happen to reproduce it from VS 2015 (update 2) To repo there Create a new project File -> New Project -> Visual C# -> .Windows -> .NET Core Console Application (.NET COre) You get a new project with a project.json which has type property in dependencies "dependencies": { Then I wanted to upgrade Microsoft.NETCore.App to the latest private drop. I did this by right cliking on the 'References' node in the solution, -> Manage Nuget Packages. I have made a feed for the myget repo (if you don't already have it) https://dotnet.myget.org/F/dotnet-core/api/v3/index.json and browsed to the Microsoft.NetCore.App package, and clicked the 'upgrade icon associated with that package. Once I upgraded, if I looked at my project.json I get "dependencies": { which did the upgrade but 'lost' the "type" : "platform" property, which basically broke my app in a way that I had to go get expert help (Eric) to figure out. |
let's investigate with 3.5-beta2 - does it still repro? and investigate issue/fix. |
Yes, it repros with 3.5-beta |
This appears to be a ASPNET Tooling issue. As noted by Zhi above, we've opened an issue on them. |
@vancem noticed this when trying to upgrade a project.
This is happening for both
"type": "platform"
and"exclude": "compile"
. The latter is definitely bug and something that should be fixed. Package manager should preserve the dependency shape (properties vs not) in the project.json.The former is a different question (NuGet from updating the shared framework) which I'll leave out of this issue. /cc @piotrpmsft
The text was updated successfully, but these errors were encountered: