Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty folders in NuGet package meaning #3009

Closed
rrelyea opened this issue Jun 21, 2016 · 8 comments
Closed

Empty folders in NuGet package meaning #3009

rrelyea opened this issue Jun 21, 2016 · 8 comments
Assignees
@harikmenon @karann-msft
Labels
Area:PackageDefinition Type:Docs
Milestone
3.5 Beta2

Comments

@rrelyea
Copy link
Contributor

rrelyea commented Jun 21, 2016

Per email, please investigate.
@rrelyea rrelyea added this to the 3.5 Beta2 milestone Jun 21, 2016
@rrelyea rrelyea added the Priority:1 High priority issues that must be resolved in the current sprint. label Jun 21, 2016
@rrelyea
Copy link
Contributor Author

rrelyea commented Jun 21, 2016

Would love to understand if this is a DCR, or if we regressed behavior.

@spadapet
Copy link

@rrelyea @yishaigalatzer

See my email reply, this looked like a DCR. I repro in VS2013.

@spadapet
Copy link

This issue comes from the latest comment in #1104
That screenshot of the docs in the other issue seems to come from the 2.2 release notes:
https://docs.nuget.org/release-notes/nuget-2.2

@harikm86 are there any docs that still incorrectly suggest that empty content directories work? If so the doc should be fixed

@spadapet spadapet assigned harikmenon and unassigned spadapet Jun 21, 2016
@rrelyea rrelyea added Type:Docs and removed Priority:1 High priority issues that must be resolved in the current sprint. Type:Bug labels Jun 22, 2016
@harikmenon harikmenon removed their assignment Jun 23, 2016
@harikmenon
Copy link

Other than this http://docs.nuget.org/Create/Nuspec-Reference, I was not able to find any reference so i believe we are good. the reference here did not pertain to the problem at hand.

@yishaigalatzer
Copy link

Let's add a clarifying comment on the 2.2 release notes

@harikmenon harikmenon self-assigned this Jun 23, 2016
@harikmenon
Copy link

Will work with Peter on the text tomorrow.

@rrelyea rrelyea changed the title Empty folders in NuGet package investigation Empty folders in NuGet package meaning Jun 23, 2016
@harikmenon
Copy link

@karann-msft : please work with Rob and Peter to update the 2.2 release notes. This will probably be your first commit to NuGet, so congrats in advance :)

karann-msft added a commit to NuGet/NuGetDocs that referenced this issue Jun 24, 2016
@karann-msft
Update NuGet-2.2.md
db71a4a 
Per NuGet/Home#3009
Removed the line "This feature also enables package authors to easily create empty directories by specifying an empty directory in the NuSpec package."
Added a clarification "Empty folders in the "content" folder are ignored when installing the package"
@karann-msft karann-msft mentioned this issue Jun 24, 2016
Merged
@harikmenon
Copy link

this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harikmenon harikmenon

@karann-msft karann-msft

Labels
Area:PackageDefinition Type:Docs
Projects
None yet
Milestone
3.5 Beta2
Development

No branches or pull requests
5 participants
@yishaigalatzer @spadapet @rrelyea @harikmenon @karann-msft