Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build assets to the TFM compatibility check and assets file #3296

Closed
emgarten opened this issue Aug 10, 2016 · 2 comments
Closed

Add build assets to the TFM compatibility check and assets file #3296

emgarten opened this issue Aug 10, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@emgarten
Copy link
Member

The guardrails compatibility check for target frameworks is built for xproj/project.json and ignores build assets.

With the move to MSBuild NuGet should include build assets during the compat check, and it should also write these items to the lock file to make it clear that they are assets selected from the package.

@karann-msft
Copy link
Contributor

@rrelyea rrelyea added this to the 3.6 Beta2 milestone Sep 7, 2016
@rrelyea rrelyea added Functionality:Restore Type:DCR Design Change Request labels Sep 7, 2016
@emgarten
Copy link
Member Author

Fixed with NuGet/NuGet.Client@efae789

@emgarten emgarten modified the milestones: 4.0 RTM, Future-1 Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants