vsfeedback: nuget manager ui for solution crashes when you select all projects #4191

Closed
rrelyea opened this Issue Jan 4, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@rrelyea
Contributor

rrelyea commented Jan 4, 2017

vs feedback issue: 732919 (talk to rob about how to access) == also 732432

nuget manager crashes vs2017rc1

  1. open solution
  2. tools -> nuget package manager -> manage nuget packages for solution...
  3. select package
  4. click project checkbox to select all projects
    -crashes-

I'll attach a recording...

@zhili1208

This comment has been minimized.

Show comment
Hide comment
@zhili1208

zhili1208 Jan 4, 2017

Contributor

from the dump file, I get the repro, following is repro step:

  1. open solution
  2. install newtonsoft.json
  3. disable all available package sources, and create an unavailable source like https://test.
    only enable this source.
  4. open NuGet solution UI.
  5. select newtonsoft.json
  6. click project checkbox to select all projects.

crashes.

the issue is from here https://github.com/NuGet/NuGet.Client/blob/4cccb13833ad29d6a0bcff055460d964f1b49cfe/src/NuGet.Clients/PackageManagement.UI/Models/PackageSolutionDetailControlModel.cs#L134

if source is bad, server will return null for package versions, the UI throws null ref exception in this case

Contributor

zhili1208 commented Jan 4, 2017

from the dump file, I get the repro, following is repro step:

  1. open solution
  2. install newtonsoft.json
  3. disable all available package sources, and create an unavailable source like https://test.
    only enable this source.
  4. open NuGet solution UI.
  5. select newtonsoft.json
  6. click project checkbox to select all projects.

crashes.

the issue is from here https://github.com/NuGet/NuGet.Client/blob/4cccb13833ad29d6a0bcff055460d964f1b49cfe/src/NuGet.Clients/PackageManagement.UI/Models/PackageSolutionDetailControlModel.cs#L134

if source is bad, server will return null for package versions, the UI throws null ref exception in this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment