Perf/UIHang - Improve DownloadTimeoutStream reads #4266

Closed
rrelyea opened this Issue Jan 12, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@rrelyea
Contributor

rrelyea commented Jan 12, 2017

See internal bug 365384:
These are 15 sec+ hangs where the IDE is unresponsive, and this is the #3 hitter in RC.2, so please investigate.

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Jan 18, 2017

Contributor

This could be related to the JTF and improved by the current fix to use a CPS enabled JTF.

Contributor

emgarten commented Jan 18, 2017

This could be related to the JTF and improved by the current fix to use a CPS enabled JTF.

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Jan 19, 2017

Improve DownloadTimeoutStream reads
This change avoids calls to DownloadTimeoutStream.Read by reading streams into MemoryStreams using CopyToStreamAsync which uses DownloadTimeoutStream.ReadAsync instead.

Fixes NuGet/Home#4266

@emgarten emgarten referenced this issue in NuGet/NuGet.Client Jan 19, 2017

Merged

Improve DownloadTimeoutStream reads #1134

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Jan 19, 2017

Contributor

I've tracked this down to the feed parser for v2 and v3 loading XML and json synchronously from DownloadTimeoutStream when there is no cache being used, which is almost always the case for the UI.

Contributor

emgarten commented Jan 19, 2017

I've tracked this down to the feed parser for v2 and v3 loading XML and json synchronously from DownloadTimeoutStream when there is no cache being used, which is almost always the case for the UI.

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Jan 20, 2017

Improve DownloadTimeoutStream reads
This change avoids calls to DownloadTimeoutStream.Read by reading streams into MemoryStreams using CopyToStreamAsync which uses DownloadTimeoutStream.ReadAsync instead.

Fixes NuGet/Home#4266

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Jan 20, 2017

Improve DownloadTimeoutStream reads
This change avoids calls to DownloadTimeoutStream.Read by reading streams into MemoryStreams using CopyToStreamAsync which uses DownloadTimeoutStream.ReadAsync instead.

Fixes NuGet/Home#4266

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Jan 20, 2017

Improve DownloadTimeoutStream reads
This change avoids calls to DownloadTimeoutStream.Read by reading streams into MemoryStreams using CopyToStreamAsync which uses DownloadTimeoutStream.ReadAsync instead.

Fixes NuGet/Home#4266

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Jan 20, 2017

Improve DownloadTimeoutStream reads
This change avoids calls to DownloadTimeoutStream.Read by reading streams into MemoryStreams using CopyToStreamAsync which uses DownloadTimeoutStream.ReadAsync instead.

Fixes NuGet/Home#4266

@rrelyea rrelyea changed the title from [Watson] visualstudiononfatalerrors2: VSNONFATALERROR_80000003_devenv.exe!vs.core.delaynotification_unknown_NuGet.Protocol.Core.v3_NuGet.Protocol.DownloadTimeoutStream.Read_unknown__InstrumentDelayNotification to Perf/UIHang - Improve DownloadTimeoutStream reads Mar 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment