Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf/UIHang - Improve DownloadTimeoutStream reads #4266

Closed
rrelyea opened this issue Jan 12, 2017 · 2 comments
Closed

Perf/UIHang - Improve DownloadTimeoutStream reads #4266

rrelyea opened this issue Jan 12, 2017 · 2 comments
Assignees
@emgarten
Labels
Product:VS.Client Tenet:Performance Performance issues Type:Bug
Milestone
4.0 RC4

Comments

@rrelyea
Copy link
Contributor

rrelyea commented Jan 12, 2017

See internal bug 365384:
These are 15 sec+ hangs where the IDE is unresponsive, and this is the #3 hitter in RC.2, so please investigate.
@rrelyea rrelyea added this to the 4.0 RTM milestone Jan 12, 2017
@emgarten
Copy link
Member

This could be related to the JTF and improved by the current fix to use a CPS enabled JTF.

@emgarten emgarten mentioned this issue Jan 19, 2017
Merged
@emgarten
Copy link
Member

I've tracked this down to the feed parser for v2 and v3 loading XML and json synchronously from DownloadTimeoutStream when there is no cache being used, which is almost always the case for the UI.

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Jan 20, 2017
@emgarten
Improve DownloadTimeoutStream reads
ff6503c 
This change avoids calls to DownloadTimeoutStream.Read by reading streams into MemoryStreams using CopyToStreamAsync which uses DownloadTimeoutStream.ReadAsync instead.

Fixes NuGet/Home#4266
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Jan 20, 2017
@emgarten
Improve DownloadTimeoutStream reads
24b9c1b 
This change avoids calls to DownloadTimeoutStream.Read by reading streams into MemoryStreams using CopyToStreamAsync which uses DownloadTimeoutStream.ReadAsync instead.

Fixes NuGet/Home#4266
@rrelyea rrelyea changed the title [Watson] visualstudiononfatalerrors2: VSNONFATALERROR_80000003_devenv.exe!vs.core.delaynotification_unknown_NuGet.Protocol.Core.v3_NuGet.Protocol.DownloadTimeoutStream.Read_unknown__InstrumentDelayNotification Perf/UIHang - Improve DownloadTimeoutStream reads Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emgarten emgarten

Labels
Product:VS.Client Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
4.0 RC4
Development

No branches or pull requests
3 participants
@emgarten @rrelyea @karann-msft