Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore not working on net core projects which have no unconditional package references #4416

Closed
rohit21agrawal opened this issue Jan 27, 2017 · 4 comments

Comments

@rohit21agrawal
Copy link
Contributor

rohit21agrawal commented Jan 27, 2017

CLI build system is hitting this when building the following test assets:

https://github.com/dotnet/cli/blob/rel/1.0.0/TestAssets/TestPackages/dotnet-desktop-and-portable/dotnet-desktop-and-portable.csproj

https://github.com/dotnet/cli/blob/rel/1.0.0/TestAssets/TestProjects/DependencyContextFromTool/DependencyContextFromTool.csproj

Note : Doesn't repro in an isolated project, likely the cause is the build process of the dotnet cli repository.

@rrelyea
Copy link
Contributor

rrelyea commented Feb 7, 2017

Likely 4.0.1 - can you do quick analysis so we can triage.

@emgarten
Copy link
Member

emgarten commented Feb 7, 2017

Investigating

@emgarten
Copy link
Member

emgarten commented Feb 7, 2017

I'm not seeing any issues in the CLI after removing this workaround for tests. I'm also unable to repro any problems locally with conditional dependencies.

@emgarten
Copy link
Member

emgarten commented Feb 8, 2017

Fixed in the CLI by removing the workaround.

@emgarten emgarten closed this as completed Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants