Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable .NET Core 2.0 projects to work with .NET Framework 4.6.1 compatible packages #5192

Closed
emgarten opened this issue May 8, 2017 · 1 comment
Closed

Enable .NET Core 2.0 projects to work with .NET Framework 4.6.1 compatible packages #5192

emgarten opened this issue May 8, 2017 · 1 comment
Assignees
@emgarten
Labels
Area:PackageDefinition Functionality:Restore Type:Feature
Milestone
4.3 - 5/30 thru 6/16

Comments

@emgarten
Copy link
Member

emgarten commented May 8, 2017 •
edited by anangaur

  • Dependency groups are selected independently, there are no changes for walking the graph
  • If any assets are available within a package including non-TFM specific assets then no fallback is done
  • If zero assets are available and the package would be considered incompatible, then and only then fallback to trying with PackageTargetFallback to select assets
  • Compatible assets are determined by what the project is going to select, other folders such as content/ and tools/ are ignored

This needs investigation to see if existing packages on the gallery would be broken. And also if this behavior would even fix all packages in a real solution when using a fall back of net461

[anangaur] Spec: https://github.com/NuGet/Home/wiki/Enable-.NET-Core-2.0-projects-to-work-with-.NET-Framework-4.6.1-compatible-packages
@emgarten emgarten added this to the 4.3 - 5/8 thru 5/27 milestone May 8, 2017
@emgarten emgarten self-assigned this May 8, 2017
@anangaur anangaur changed the title Soft framework fallback for PackageTargetFallback Enable .NET Core 2.0 projects to work with .NET Framework 4.6.1 compatible packages Jun 1, 2017
@anangaur
Copy link
Member

anangaur commented Jun 1, 2017

Added the spec to the issue description

@emgarten emgarten mentioned this issue Jun 2, 2017
Closed
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Jun 2, 2017
@emgarten
Add support for AssetTargetFallback
2be8291 
AssetTargetFallback allows falling back to another project framework only if no compatible assets are found in the package.

Fixes NuGet/Home#5192
Fixes NuGet/Home#5268
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Jun 2, 2017
@emgarten
Add support for AssetTargetFallback
83002f4 
AssetTargetFallback allows falling back to another project framework only if no compatible assets are found in the package.

Fixes NuGet/Home#5192
Fixes NuGet/Home#5268
@weshaggard weshaggard mentioned this issue Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emgarten emgarten

Labels
Area:PackageDefinition Functionality:Restore Type:Feature
Projects
None yet
Milestone
4.3 - 5/30 thru 6/16
Development

No branches or pull requests
2 participants
@emgarten @anangaur