Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow sources cause update to be slower #5495

Closed
JarahSi opened this issue Jun 26, 2017 · 9 comments
Closed

Slow sources cause update to be slower #5495

JarahSi opened this issue Jun 26, 2017 · 9 comments
Labels
Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Style:Packages.Config Tenet:Performance Performance issues Type:Bug
Milestone

Comments

@JarahSi
Copy link

JarahSi commented Jun 26, 2017

Steps to reproduce:

  1. git clone https://github.com/NuGet/NuGetGallery.git
  2. open NuGetGallery.sln
  3. open PMC
  4. Install-Package WebGrease -Version 1.6.0

Expected: Update result should appear quickly
Actual: Update result takes 20+ minutes to appear

VS 15.3.0 Preview 3.0 [26614.0.d15rel]

Nuget.exe 4.3.0.4146

Attempted similar steps with nuget.exe update

/cc @emgarten @jainaashish

@zhili1208
Copy link
Contributor

it took very long time to gather dependency information for package 'WebGrease.1.6.0'.

@zhili1208
Copy link
Contributor

looks like a dupe of #1909

@jainaashish jainaashish self-assigned this Jun 28, 2017
@phatcher
Copy link

phatcher commented Jul 3, 2017

Yes but they closed that over a year ago and have yet to re-open it.

I'm updating a project with a minor update to a package and it's taking over 8 mins per project!

This is badly broken and needs to be addressed

@jainaashish
Copy link
Contributor

I looked at the NuGetGallery solution issue, it took all that time for http calls to gather results for each package installed across all the sources configured. There were 6 sources out of those, myget dotnet-core feed (https://dotnet.myget.org/F/dotnet-core/api/v3/index.json) took the most time.

You can do two things to improve this experience for now:

  1. Disable dotnet-core or any other source which you don't need for your update operation. It will improve it significantly, like in this case, I only enabled nuget.org source and it took less than a minute to show the preview window.

  2. Move to PackageReference world from packages.config... since packages.config is a flat dependencies list so we don't differentiate between top level dependency vs transitive.

Meantime, I'll dig more into packages.config and see, if we can do something to improve this overall experience.

@jainaashish
Copy link
Contributor

@phatcher you can also try one of the above solutions to improve your experience and let us know how it goes... if you still see issues, then give us a repro solution and we'll be happy to look into that.

@jainaashish jainaashish modified the milestones: 4.3, Future-2 Jul 3, 2017
@phatcher
Copy link

@jainaashish I updated a 91 project solution yesterday which is just using the official v3 feed - it took over 3 hours to process the update of a single package.

I'll see if I can get a simple repro

@jainaashish
Copy link
Contributor

@phatcher any luck with the repro?

@jainaashish jainaashish modified the milestones: Backlog, Future-2 Aug 17, 2017
@jainaashish jainaashish added the Priority:2 Issues for the current backlog. label Aug 17, 2017
@rrelyea rrelyea added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed Priority:2 Issues for the current backlog. labels Aug 22, 2017
@rrelyea rrelyea changed the title Slow update in packages.config Slow sources cause update to be slower Aug 22, 2017
@rrelyea
Copy link
Contributor

rrelyea commented Aug 22, 2017

lowering priority as this isn't easy to address.
best long term move for nuget is to get more people moved to transitive systems (like PackageReference).

@nkolev92
Copy link
Member

Many issues in this area have been addressed (from batching to networking etc).
We also have diagnostics to actually confirm that networking issues are a root cause of the slowness.

At this point this issue is too vague and not targeting a specific issue, so closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Style:Packages.Config Tenet:Performance Performance issues Type:Bug
Projects
None yet
Development

No branches or pull requests

7 participants