Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages at solution updates/ installs for all the projects #5508

Closed
jainaashish opened this issue Jun 29, 2017 · 1 comment · Fixed by NuGet/NuGet.Client#1698
Closed
Assignees
Labels
Functionality:Update The update package feature/command/experience RegressionFromPreviousRTM A regression from the last RTM. Example: worked in 6.2, doesn't work in 6.3 Type:Bug
Milestone

Comments

@jainaashish
Copy link
Contributor

jainaashish commented Jun 29, 2017

while updating packages at solution level, it checks for all the projects in solution irrespective of the fact that not all the updating packages are applicable for all the projects and construct installing/ uninstalling actions for all the projects. This is wrong, it should always check for the projects where list of updating packages applies.

This is a regression post 3.5.0 release for VS 2017.

More details from one of the customer repro: Customer was trying to update his own 15 packages from a local feed.

Current code with VS2017 - shows total 86 installs across 18 projects for different combination of 28 packages (even installing packages out of those 15)
image

Where as it should have shown total 38 installs across 6 projects for different combination of 15 packages.

This particular scenario regressed update performance by ~10 mins (almost 100% regression from base time)

@rrelyea
Copy link
Contributor

rrelyea commented Jul 6, 2017

moving to 4.4 since we are in escrow for 4.3 and have no direct customer asking for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Update The update package feature/command/experience RegressionFromPreviousRTM A regression from the last RTM. Example: worked in 6.2, doesn't work in 6.3 Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants