NU1701 - Change the wording of this warning

[g0t4]

In a netcoreapp2.0 project, if I add a package that targets net461, I get a new warning as of 2.0 preview2:

/api/api.csproj : warning NU1701: Package 'Faker.Net 1.0.3' was restored using '.NETFramework,Version=v4.6.1' instead the project target framework '.NETCoreApp,Version=v2.0'. This may cause compatibility problems.

I had a hunch that this was just warning me about the new behavior in 2.0 to reference netfx packages. But I wasn't certain from the message alone. Upon looking up NU1701 here https://github.com/NuGet/Home/wiki/Restore-errors-and-warnings#nu1701 I found an explanation that I understood:

PackageTargetFallback was used to select assets from a package. This is a warning to let the user know that the assets may not be 100% compatible.

Two things helped me verify what the warning was really about: PackageTargetFallback was used to select assets and may not be 100% compatible

Could we use some of this explanation in the warning?

Perhaps:

/api/api.csproj : warning NU1701: Package 'Faker.Net 1.0.3' was restored using '.NETFramework,Version=v4.6.1' instead the project target framework '.NETCoreApp,Version=v2.0'. This package may not be 100% compatible.

or

/api/api.csproj : warning NU1701: Package 'Faker.Net 1.0.3' was restored using '.NETFramework,Version=v4.6.1' instead the project target framework '.NETCoreApp,Version=v2.0'. This package may not be 100% compatible because AssetTargetFallback was used to select assets from this package.

[emgarten]

@anangaur would you take a look at the text of this message?

[anangaur]

I like the first suggestion. I would avoid the use of PackageTargetFallback or AssetTargetFallback terms here as that's unnecessary confusion.

Proposed text:

/api/api.csproj : warning NU1701: Package 'Faker.Net 1.0.3' was restored using '.NETFramework,Version=v4.6.1' instead the project target framework '.NETCoreApp,Version=v2.0'. This package may not be fully compatible with your project.

[g0t4]

Sounds good to me, if you want I can create a PR

…

--

---------- On Wed, Jul 5, 2017 at 7:27 PM, Anand Gaurav <notifications@github.com> wrote: I like the first suggestion. I would avoid the use of PackageTargetFallback or AssetTargetFallback terms here as that's unnecessary confusion. Proposed text: /api/api.csproj : warning NU1701: Package 'Faker.Net 1.0.3' was restored using '.NETFramework,Version=v4.6.1' instead the project target framework '.NETCoreApp,Version=v2.0'. This package may not be fully compatible with your project. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5538 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAK_3bzdTJ4YK6a3jPShwkUceMbGAtWNks5sLBvLgaJpZM4OOgfK> .

[anangaur]

Sure. Go ahead. :)

[g0t4]

Should I update the message in https://github.com/NuGet/NuGet.Build.Localization?

i.e. https://github.com/NuGet/NuGet.Build.Localization/blob/8f3a16696bfaf39c22963fcd21feb9cdf5d66eed/localize/ITA/15/NuGet.Commands.dll.lcl#L945

I obviously can't update all the translations :)

[emgarten]

@g0t4 you don't need to worry about localization, that will be updated later.

[g0t4]

PR ready, do we need to do anything to make sure that the wiki and localization get updated? Create issues?

wiki: https://github.com/NuGet/Home/wiki/Restore-errors-and-warnings#nu1701

[rohit21agrawal]

@g0t4 you don't have to worry about localization at all.

[anangaur]

I made the changes to the wiki