-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--interactive support for dotnet remove package #7727
Comments
Also in the title you talk about list and remove, but in the issue you talk about MSBUIlD SDKs as well. The MSBuild SDKs scenario has been addressed in NuGet/NuGet.Client@62916a4#diff-2cd243ce1cd32fce987422c201afe90d |
I don't think it is the same as NuGet/NuGet.Client@62916a4#diff-2cd243ce1cd32fce987422c201afe90d. This issue more tricky. For #7605, if a feed is behind private feed. At least it can pass msbuild evaluation phase. But if there is an msbuild sdk behind private feed. Even the evaluation will fail. I am not sure the implementation of nuget auth. The solution of 7605 may work for msbuild sdk as well, but please double check this scenario.
I am not familiar with the redirect to nuget code in CLI. It would be nice for you to also address the code on CLI side. |
@wli3 I will do the change on NuGet side, and I'll try to work with you to validate it correctly. I assume the remove package reference addition can target 2.1.6xx, while the dotnet list package one can target 2.2.2xx? |
@nkolev92 2.1.6xx and 2.2.2xx is not necessary since "--interactive in most commands" are in 3.0.1xx. But is also ok to add it. |
Both PRs are out. @wli3 We should clarify with the PMs + Rob if the the RemovePackageReference --interactive is something that makes sense. |
These 2 commands in CLI are just a redirect command to nuget.xplat.
If there is a project used a msbuild sdk that is in a private nuget feed. These 2 commands will fail. At the same time, dotnet add package with --interactive will succeed. So doing the similar work for dotnet add package should resolve the problem.
csproj:
The text was updated successfully, but these errors were encountered: