Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise a deprecation warning for Gen1 credential plugin #7819

Closed
nkolev92 opened this issue Feb 20, 2019 · 2 comments
Closed

Raise a deprecation warning for Gen1 credential plugin #7819

nkolev92 opened this issue Feb 20, 2019 · 2 comments
Assignees
@nkolev92
Labels
Area:Logging Product:NuGet.exe NuGet.exe Type:DCR Design Change Request
Milestone
5.0

Comments

@nkolev92
Copy link
Member

nkolev92 commented Feb 20, 2019 •
edited by rrelyea
Loading

We shipped Gen2 of Authentication Credential Provider: #6642 shipped in 4.8/2.1.400 SDK/15.8 of Msbuild.

We should deprecate the Gen1 plugin in 5.0 and completely remove it in a future release.
This task is to provide a warning message if you are using the Gen1 provider in 5.0.

Future task to remove Gen1 support is: #7586.
@nkolev92 nkolev92 self-assigned this Feb 20, 2019
@nkolev92 nkolev92 added this to the 5.0 milestone Feb 20, 2019
@nkolev92 nkolev92 added Type:DCR Design Change Request Area:Logging Product:NuGet.exe NuGet.exe and removed Type:DCR Design Change Request labels Feb 20, 2019
@nkolev92 nkolev92 mentioned this issue Feb 20, 2019
Open
@nkolev92
Copy link
Member Author

@anangaur @karann-msft

I am linking to https://docs.microsoft.com/en-us/nuget/reference/extensibility/nuget-cross-platform-authentication-plugin in the warning message.

Can I get a redirect link to account for the docs potentially changing.

@karann-msft
Copy link
Contributor

https://aka.ms/nuget-cross-platform-authentication-plugin

@nkolev92 nkolev92 mentioned this issue Mar 18, 2019
Merged
@rrelyea rrelyea added CLI RTM and removed CLI RTM labels Apr 1, 2019
@rrelyea rrelyea changed the title Add a deprecation warning for the old credential plugin Add a deprecation warning for Gen1 credential plugin Apr 2, 2019
@rrelyea rrelyea added the Type:DCR Design Change Request label Apr 2, 2019
@rrelyea rrelyea changed the title Add a deprecation warning for Gen1 credential plugin Raise a deprecation warning for Gen1 credential plugin Apr 3, 2019
@karann-msft karann-msft mentioned this issue Apr 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Area:Logging Product:NuGet.exe NuGet.exe Type:DCR Design Change Request
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
4 participants
@nkolev92 @rrelyea @karann-msft @DoRonMotter