Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: exception details lost during plugin creation #8057

Closed
dtivel opened this issue Apr 24, 2019 · 1 comment · Fixed by NuGet/NuGet.Client#2838
Closed

Plugins: exception details lost during plugin creation #8057

dtivel opened this issue Apr 24, 2019 · 1 comment · Fixed by NuGet/NuGet.Client#2838
Assignees
@dtivel
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Area:Plugin V2 plugin w/ cross platform support Type:Bug
Milestone
5.1

Comments

@dtivel
Copy link
Contributor

dtivel commented Apr 24, 2019

If plugin creation fails, the exception details are lost here.

Then, a "A task was canceled." error is reported with no callstack.
@dtivel dtivel added Type:Bug Area:ErrorHandling warnings and errors/log messages & related error codes. Area:Plugin V2 plugin w/ cross platform support Sprint 152 labels Apr 24, 2019
@dtivel dtivel added this to the 5.1 milestone Apr 24, 2019
@dtivel dtivel self-assigned this Apr 24, 2019
@nkolev92
Copy link
Member

That's a message that surfaces to the user.
Do we want the stack trace to face the user as well?

Probably need to enhance the creation result somehow to avoid showing the stack trace to the user.

@dtivel dtivel mentioned this issue May 2, 2019
Merged
dtivel added a commit to NuGet/NuGet.Client that referenced this issue May 3, 2019
@dtivel
Plugins: propagate plugin exception (#2838)
0690359 
Resolve NuGet/Home#8057.
dtivel added a commit to NuGet/NuGet.Client that referenced this issue May 3, 2019
@dtivel
Plugins: propagate plugin exception (#2838)
f34e467 
Resolve NuGet/Home#8057.
@maartenba maartenba mentioned this issue Jul 18, 2019
Merged
@nkolev92 nkolev92 mentioned this issue Jul 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtivel dtivel

Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Area:Plugin V2 plugin w/ cross platform support Type:Bug
Projects
None yet
Milestone
5.1
Development

Successfully merging a pull request may close this issue.

Plugins: propagate plugin exception NuGet/NuGet.Client
2 participants
@nkolev92 @dtivel