Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Failure] Suggest removing the second duplicated string “License Acceptance” in “License Acceptance” dialog #8162

Closed
v-luzh opened this issue May 27, 2019 · 2 comments · Fixed by NuGet/NuGet.Client#4257

Comments

@v-luzh
Copy link

v-luzh commented May 27, 2019

Details about Problem

NuGet version: NuGet Client Dev\5.2.0.6028
VS Version: D16.2stg\28925.13
OS: Windows 10 RS4_Release 17134.1.180410-1804

Detailed repro steps so we can see the same problem

  1. Launch VS and create an ASP.NET Web Application (.NET Framework).
  2. Open PM UI of this project.
  3. Select “Updates” tab and then the package “Microsoft.CodeDom.Providers.DotNetCompilerPlatform”.
  4. Click “Update” button on the right and click “OK” button in the opened “Preview Changes” dialog.

Expected

There is no duplicated string “License Acceptance” in “License Acceptance” dialog.

Actual

There is a duplicated string “License Acceptance” in “License Acceptance” dialog as below screenshot. (There is no need to show the string “License Acceptance” again since the dialog is called “License Acceptance”)
LicenseAcceptance

Note

It is not a regression issue since it did repro on D15.9 28307.158 (Nuget Client 4.9.3.5777).

@nkolev92 nkolev92 modified the milestones: 5.2, Backlog May 29, 2019
@nkolev92 nkolev92 added the Priority:2 Issues for the current backlog. label May 29, 2019
@v-luzh v-luzh changed the title [Test Failure] Suggest to remove the second duplicated string “License Acceptance” in “License Acceptance” dialog [Test Failure] Suggest removing the second duplicated string “License Acceptance” in “License Acceptance” dialog Feb 26, 2020
@donnie-msft donnie-msft added this to Needs triage in VS PMUI Triage Oct 1, 2020
@donnie-msft donnie-msft moved this from Needs triage to Low priority in VS PMUI Triage Nov 14, 2020
@donnie-msft
Copy link
Contributor

donnie-msft commented Jan 5, 2021

address together with #8065

@v-luzh
Copy link
Author

v-luzh commented Sep 24, 2021

It is fixed after verifying on Main\31723.272+NuGet Dev\6.0.0.259. Thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants