Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link “View License” in License Acceptance window can be tabbed to at the second time #8065

Closed
v-luzh opened this issue Apr 26, 2019 · 3 comments

Comments

@v-luzh
Copy link

v-luzh commented Apr 26, 2019

Details about Problem

NuGet version: NuGet Client Release-5.1.x\5.1.0.5984
VS Version: D16.1stg\28825.240
OS: Windows 10 RS4_Release 17134.1.180410-1804

Detailed repro steps

  1. Open VS (in “Dark” theme) and create a C# Console App (.NET Framework) project.
  2. Open PM UI of this project.
  3. Select a package in “Browse” tab (e.g. “NUnit”) and click "Install" button.
  4. Click "OK" button in the opened "Preview Changes" window
  5. Tab through the opened License Acceptance window.

Expected

The link “View License” should be tabbed to at the first time with a clear dashed line box in the License Acceptance window.

Actual

  1. The external border of “License” is selected (the dashed line box is black in VS Dark them-it is had to see) at the first tab. Please see below screenshot.
  2. The link “View License” can be tabbed to at the second time as below screenshot.
    image

Note

  1. It also repro on PM UI at solution level.
  2. It also repro on D16.0 28625.133, D15.9 28307.158.
  3. It didn’t repro on D15.8 28010.2050.
@v-luzh
Copy link
Author

v-luzh commented May 27, 2019

It also repro in License Acceptance Window, please fix them together, thanks.

@v-luzh
Copy link
Author

v-luzh commented Feb 20, 2020

The original issue is fixed on D16.5\29819.164 + NuGet Client Release-5.5.x\5.5.0.6449, but it still exist in License Acceptance window as below.
image

@donnie-msft donnie-msft changed the title [Bug Bash][Test Failure][Accessibility] The link “View License” can be tabbed to at the second time The link “View License” can be tabbed to at the second time Nov 3, 2020
@donnie-msft donnie-msft changed the title The link “View License” can be tabbed to at the second time The link “View License” in License Acceptance window can be tabbed to at the second time Jan 5, 2021
@v-luzh
Copy link
Author

v-luzh commented Aug 12, 2021

This issue is fixed on Main\31611.101 + NuGet Client Dev\6.0.0.189 [Fix tab stop accessibility issue in license acceptance window (#4192)]. Close this bug now. Thanks.

@v-luzh v-luzh closed this as completed Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants