Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: improve diagnosability of plugin launch failure #8271

Closed
dtivel opened this issue Jun 27, 2019 · 2 comments · Fixed by NuGet/NuGet.Client#2907
Closed

Plugins: improve diagnosability of plugin launch failure #8271

dtivel opened this issue Jun 27, 2019 · 2 comments · Fixed by NuGet/NuGet.Client#2907
Assignees
@dtivel
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Area:Plugin V2 plugin w/ cross platform support Type:Bug
Milestone
5.2

Comments

@dtivel
Copy link
Contributor

dtivel commented Jun 27, 2019

If a plugin fails on launch --- say, because of an unhandled exception --- or if a plugin times out during handshake, the error message ("A task was canceled.") here is unhelpful.
@dtivel dtivel added Area:ErrorHandling warnings and errors/log messages & related error codes. Area:Plugin V2 plugin w/ cross platform support Sprint 155 labels Jun 27, 2019
@dtivel dtivel added this to the 5.2 milestone Jun 27, 2019
@dtivel dtivel self-assigned this Jun 27, 2019
@dtivel dtivel mentioned this issue Jun 27, 2019
Merged
@dtivel dtivel modified the milestones: 5.2, 5.3 Jul 1, 2019
dtivel added a commit to NuGet/NuGet.Client that referenced this issue Jul 1, 2019
@dtivel
Plugins: improve error message when plugin start fails (#2907)
9ae6dcb 
Fix NuGet/Home#8271.
dtivel added a commit to NuGet/NuGet.Client that referenced this issue Jul 9, 2019
@dtivel
Plugins: improve error message when plugin start fails (#2907)
7139100 
Fix NuGet/Home#8271.
@dtivel dtivel modified the milestones: 5.3, 5.2 Jul 10, 2019
@dtivel
Copy link
Contributor Author

dtivel commented Jul 10, 2019

Should be first available in NuGet.exe 5.2.x, and generally available (VS, dotnet.exe) in 5.3.x.

@rrelyea
Copy link
Contributor

rrelyea commented Jul 11, 2019

(added missing bug metadata so this shows up correctly in release notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtivel dtivel

Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Area:Plugin V2 plugin w/ cross platform support Type:Bug
Projects
None yet
Milestone
5.2
Development

Successfully merging a pull request may close this issue.

Plugins: improve error message when plugin start fails NuGet/NuGet.Client
2 participants
@rrelyea @dtivel