Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet should support multiple config files in %APPDATA%\NuGet directory #9394

Closed
debonte opened this issue Apr 3, 2020 · 1 comment · Fixed by NuGet/NuGet.Client#3421
Closed
Assignees
Labels
Area:Settings NuGet.Config and related issues Priority:1 High priority issues that must be resolved in the current sprint. Type:Feature

Comments

@debonte
Copy link

debonte commented Apr 3, 2020

Details about Problem

NuGet product used: VS UI
NuGet version: 5.6.0.6489
VS version: 16.7
Worked before?: No

Detailed repro steps so we can see the same problem

  1. Unzip SomeOther.zip
  2. Place SomeOther.config in %APPDATA%\NuGet. This config file declares a single package source named "IssueRepro"
  3. Start VS and open/create some project
  4. Open NuGet Package Manager
  5. Expand "Package source" combo box

Expected: IssueRepro source is one of the options.

Actual: IssueRepro source is not shown as an option.

Workarounds:

  1. Place the file in %ProgramFiles(x86)%\NuGet\Config instead.
  2. Merge the IssueRepro package source into %APPDATA%\NuGet\NuGet.Config's list of package sources.

Note that what I really care about is fallback folders, but I'm using package sources for ease of repro.

Reasoning

The XAML and WinForms teams want to allow control library installers to add user-specific NuGet fallback folders by having their SDK installers drop config files in %APPDATA%\NuGet. On uninstall this file would be deleted.

We considered two alternatives which I mentioned as workarounds above:

  1. Require SDK installers to drop config files in %ProgramFiles(x86)%\NuGet\Config instead. However, we've gotten feedback from control vendors that they would like the option of installing without elevation which prevents the installer from being able to write to this directory.
  2. Require SDK installers to modify the one %APPDATA%\NuGet\NuGet.config file. However this seems error prone.

@rrelyea @zivkan @aortiz-msft @mgoertz-msft

@aortiz-msft aortiz-msft added the Tenet:Acquisition Install of VS/other NuGet products label Apr 3, 2020
@donnie-msft donnie-msft added Area:Settings NuGet.Config and related issues Type:DCR Design Change Request and removed Tenet:Acquisition Install of VS/other NuGet products labels Apr 6, 2020
@nkolev92 nkolev92 added Type:Feature Priority:1 High priority issues that must be resolved in the current sprint. and removed Type:DCR Design Change Request labels Apr 17, 2020
@aortiz-msft aortiz-msft added this to the Sprint 170 - 2020.05.04 milestone May 1, 2020
@nkolev92
Copy link
Member

PR out NuGet/NuGet.Client#3421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Settings NuGet.Config and related issues Priority:1 High priority issues that must be resolved in the current sprint. Type:Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants