Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In static graph restore, with multi targeted projects, NuGet should read the target framework related information from the inner build. #9870

Closed
nkolev92 opened this issue Aug 3, 2020 · 0 comments · Fixed by NuGet/NuGet.Client#3568
Closed

In static graph restore, with multi targeted projects, NuGet should read the target framework related information from the inner build. #9870

nkolev92 opened this issue Aug 3, 2020 · 0 comments · Fixed by NuGet/NuGet.Client#3568
Assignees
@nkolev92
Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Functionality:Restore Priority:2 Issues for the current backlog. Product:dotnet.exe Type:Bug
Milestone
Sprint 174 - 2020...

Comments

@nkolev92
Copy link
Member

nkolev92 commented Aug 3, 2020

Child of: #9756

Currently in command line scenarios NuGet reads the target framework information in the outer build.
That is incorrect because the the contract is that we should depend on on TargetFrameworkIdentifier and the like properties.
We do that here: https://github.com/NuGet/NuGet.Client/blob/bd482514a87a0085f8eb8603842ee1cb3ca5f277/src/NuGet.Core/NuGet.Build.Tasks/NuGet.targets#L500-L526

This task covers, the static graph restore changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Functionality:Restore Priority:2 Issues for the current backlog. Product:dotnet.exe Type:Bug
Projects
None yet
Milestone
Sprint 174 - 2020.07.27
Development

Successfully merging a pull request may close this issue.

Static graph restore should read the target framework information and alias. NuGet/NuGet.Client
1 participant
@nkolev92