Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With multi targeted projects, NuGet should read the target framework related information from the inner build. #9756

Closed
3 tasks
nkolev92 opened this issue Jul 6, 2020 · 0 comments
Assignees
Labels

Comments

@nkolev92
Copy link
Member

nkolev92 commented Jul 6, 2020

Currently in command line scenarios NuGet reads the target framework information in the outer build.
That is incorrect because the the contract is that we should depend on on TargetFrameworkIdentifier and the like properties.
We do that here: https://github.com/NuGet/NuGet.Client/blob/bd482514a87a0085f8eb8603842ee1cb3ca5f277/src/NuGet.Core/NuGet.Build.Tasks/NuGet.targets#L500-L526

This task is a blocker for #5154.

An incomplete list of things that need done are:

  • In command line scenarios, read the framework in the inner build (this should allow us to read OS Version for example).
  • In VS scenarios, modify the VSSOlutionREstoreService to read the information from the properties back instead of the TargetFrameworks value.
  • Reflect all of the changes in the assets file (not sure if we'll need any).
  • Commandline restore (nuget.exe, msbuild.exe dotnet.exe).
  • Commandline Static Graph restore.
  • VS restore
@nkolev92 nkolev92 added Functionality:Restore Type:Bug Priority:2 Issues for the current backlog. labels Jul 6, 2020
@zkat zkat self-assigned this Jul 6, 2020
@zkat zkat added this to the Sprint 173 - 2020.07.24 milestone Jul 6, 2020
@nkolev92 nkolev92 assigned nkolev92 and unassigned zkat Jul 28, 2020
@nkolev92 nkolev92 added the Epic label Aug 3, 2020
@nkolev92 nkolev92 assigned nkolev92 and zivkan and unassigned nkolev92 Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants