Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround account for some .NET 5 SDKs report TargetPlatformMoniker of ,Version= #9913

Closed
Tracked by #9783
nkolev92 opened this issue Aug 15, 2020 · 2 comments · Fixed by NuGet/NuGet.Client#3913
Closed
Tracked by #9783

Remove workaround account for some .NET 5 SDKs report TargetPlatformMoniker of ,Version= #9913

nkolev92 opened this issue Aug 15, 2020 · 2 comments · Fixed by NuGet/NuGet.Client#3913
Assignees
@nkolev92
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore Partner:DotNet Priority:1 High priority issues that must be resolved in the current sprint. Type:Bug
Milestone
Sprint 2021-02

Comments

@nkolev92
Copy link
Member

Different SDKs set a different TargetPlatformMoniker.
For example .NET 5 P8 and earlier would report ,Version= as TPM for the net50 TPV.
That was later fixed in dotnet/msbuild@9389d84.

In order to not run into problems with this, a hack was added in NuGet/NuGet.Client#3578.

This issue tracks the revert of that hack.
@nkolev92 nkolev92 self-assigned this Aug 15, 2020
@nkolev92 nkolev92 added Functionality:Restore Partner:DotNet Priority:2 Issues for the current backlog. Type:Bug Priority:1 High priority issues that must be resolved in the current sprint. and removed Priority:2 Issues for the current backlog. labels Aug 15, 2020
@nkolev92 nkolev92 mentioned this issue Aug 15, 2020
Merged
@JonDouglas
Copy link
Contributor

@nkolev92 should we consider this in .NET 6?

@nkolev92
Copy link
Member Author

I think we can remove it before that, in 16.9/16.10.
It was a preview workaround.

@nkolev92 nkolev92 added this to the Sprint 2021-02 milestone Feb 20, 2021
@nkolev92 nkolev92 mentioned this issue Feb 20, 2021
Merged
8 tasks
@nkolev92 nkolev92 added the Category:Quality Week Issues that should be considered for quality week label Feb 22, 2021
@zkat zkat mentioned this issue Jul 1, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore Partner:DotNet Priority:1 High priority issues that must be resolved in the current sprint. Type:Bug
Projects
None yet
Milestone
Sprint 2021-02
3 participants
@JonDouglas @nkolev92 @heng-liu