This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Use SemVer2 for simplified versioning #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having it scattered all over, keep it in PackageVersion.targets
Version PRs separately, append branch metadata and git information. Don't attach it for release branches. Only for non-master branches, having the branch name as a prerelease label makes it easier to trivially dogfood a specific feature branch, without having to tweak GitInfo.txt across branches. This change allows us to keep working on a stable version number (i.e. 0.2.5) while working on `dev` branch, so we will get version numbers like 0.2.5-dev.5+sha.asdfasdf. Branching for a feature `foo`, you'd automatically get version numbers like 0.2.5-foo.6+sha.asfdasdf. If, however, we already had a branch that's creating an already labeled release (via GitInfo.txt), such as 0.2.5-alpha, the version in (say) dev for that would be 0.2.5-alpha.15+dev.sha.asdfasdf. This allows you to tell apart a build for the alpha that's being contributed to by a specific branch.
We don't need to have it hardcoded in GitInfo.txt anymore.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.