-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the netstandard support for dotnet #209
Conversation
c61c2bd
to
36eda97
Compare
Looks good to me. One thing to consider (for the near future) is how |
@emgarten, correct me if I am wrong here, but the current code has two possibilities for this.
The third possible approach is of course implement a new kind of relationship that is something like subset mentioned above but only for TFMs with versions greater than or equal to X.Y ( |
I think @ericstj was OK with having the underlying NuGet code allow all the mappings and have the But of course, he can chime in to clarify :) |
I agree with @anurse keeping the subset rule would be best here. Forward compatibility here for nuget frameworks is typically the most important thing. Validating and restricting poorly authored packages that use incorrect frameworks is ideally done by the pack command and by nuget.org when a new package is uploaded. |
That's OK with me, but I still have hope that all of this code will go away and be replaced with a data file. |
eeb937d
to
ae85361
Compare
Agreed on the data file. I don't think anyone likes having to maintain this code ;P |
ae85361
to
59b1a03
Compare
FYI now that this is in, we're going to need NuGet/Home#1962 fairly soon. |
This addresses two different updates to the
netstandard
story:netstandard
should not supportdotnet
. See Break compatibility between netstandard and dotnet Home#1963.netstandardapp
.@emgarten @anurse @ericstj @davidfowl