Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for an array in imports #1962

Closed
analogrelay opened this issue Jan 20, 2016 · 4 comments
Closed

Add support for an array in imports #1962

analogrelay opened this issue Jan 20, 2016 · 4 comments
Assignees
Milestone

Comments

@analogrelay
Copy link

The imports syntax in project.json should support an array so that we can have multiple items. For example:

{
  "frameworks": {
    "netstandard1.2": {
      "imports": [ "dotnet5.3", "portable-net45+win8" ]
    }
  }
}

Also, currently imports must be a portable profile (i.e. portable-...). This restriction should be loosened. At a minimum, dotnet and netstandard (i.e. the new portable TFMs) should be allowed as well. Personally, I think allowing any framework to appear in this list is reasonable, since it is designed as a "Go away NuGet, I know what I want" feature for advanced usage. If someone wants to import net45 into win8, I say let 'em ;)

/cc @yishaigalatzer @lodejard @emgarten @ericstj @davidfowl

@yishaigalatzer
Copy link

should this support an Array or a single property? (I'd say yes)

@analogrelay
Copy link
Author

Yes, both is best. In general with array properties we allow a string as a short-hand for an array with one element.

@ericstj
Copy link

ericstj commented Jan 21, 2016

Additionally it looks like the imports is limited to just "PCL" frameworks. That should be opened up to more frameworks.

@analogrelay
Copy link
Author

Ah, good point. I'll update the issue to clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants