Disable cpvm transitive pinning. #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
approved these changes
Oct 15, 2020
| @@ -9795,7 +9795,7 @@ public async Task RestoreNetCore_CPVMProject_DowngradedByCentralDirectDependency | |||
| /// P will be accepted (because its parent B is Accepted) | |||
| /// S will be accepted (because its parent O 300 is Accepted) | |||
| /// </summary> | |||
| [Fact] | |||
| [Fact(Skip = "Depends on cpvm transitive pinning")] | |||
There was a problem hiding this comment.
We usually include a link to a tracking issue either as the skip reason, or as a comment next to the skipped test. This makes it easier to figure out when a test can be unskipped, or maybe deleted permanently.
| var solution = new SimpleTestSolutionContext(pathContext.SolutionRoot); | ||
| var packagesForSource = new List<SimpleTestPackageContext>(); | ||
| var packagesForProject = new List<SimpleTestPackageContext>(); | ||
| var framework = NuGetFramework.Parse("netcoreapp2.0"); |
There was a problem hiding this comment.
Suggested change
| var framework = NuGetFramework.Parse("netcoreapp2.0"); | |
| var framework = FrameworkConstants.CommonFrameworks.NetCoreApp20; |
| var projectA = SimpleTestProjectContext.CreateNETCore( | ||
| "projectA", | ||
| pathContext.SolutionRoot, | ||
| NuGetFramework.Parse("netcoreapp2.0")); |
There was a problem hiding this comment.
Suggested change
| NuGetFramework.Parse("netcoreapp2.0")); | |
| framwork); |
nkolev92
approved these changes
Oct 16, 2020
Done |
kartheekp-ms
pushed a commit
that referenced
this pull request
Oct 17, 2020
Disable cpvm transitive pinning.
cristinamanum
added a commit
that referenced
this pull request
Oct 27, 2020
Disable cpvm transitive pinning.
5 tasks
marcin-krystianc
added a commit
to marcin-krystianc/NuGet.Client
that referenced
this pull request
Apr 26, 2021
This reverts commit 087a711. # Conflicts: # test/NuGet.Clients.Tests/NuGet.CommandLine.Test/RestoreNETCoreTest.cs
marcin-krystianc
added a commit
to marcin-krystianc/NuGet.Client
that referenced
this pull request
Apr 28, 2021
…ncludeAssets reverts: NuGet#3719 Issue: NuGet/Home#10389
5 tasks
|
Hi all, I've just spent a few hours debugging a build break and root caused it as this change breaking things. For the future, it would be really nice to avoid breaking things and just provide an option to the users who need to turn it off. The default transitive pinning behavior was good for the vast majority of cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: This change disable the enforcing/pinning of package versions for transitive dependencies defined in the CentralManagement file.
NuGet/Home#10132
Regression: No
Fix
Disable transitive dependency pinning.
Testing/Validation
Tests Added: Yes
Validation: Automated and manual tests.