Don't wrap output when output has been redirected to a file. #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced as a fix for NuGet/Home#1893, which was previously fixed like I'm proposing here (NuGet/NuGet2@98d15b3). I can't see a reason to wrap output when it has been redirected to a file, so I'm proposing to apply the original fix.
nkolev92
approved these changes
Oct 29, 2020
zivkan
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#10198
Regression: I think so (since this has been fixed twice, the first time like I'm proposing here).
Fix
This was introduced as a fix for NuGet/Home#1893, which was previously fixed like I'm proposing here (NuGet/NuGet2@98d15b3).
I can't see a reason to wrap output when it has been redirected to a file, so I'm proposing to apply the original fix.
Testing/Validation
Tests Added: No
Reason for not adding tests: it would require running nuget on mono as a subprocess with output redirected to a file
Validation: