error when attempting to pack multiple files into the same destination #3923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
reviewed
Feb 24, 2021
src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs
Outdated
Show resolved
Hide resolved
donnie-msft
reviewed
Feb 24, 2021
src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs
Outdated
Show resolved
Hide resolved
zkat
force-pushed
the
dev-zkat-6941-pack-dupe-files
branch
from
2264429
to
8de50a6
Compare
src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs
Outdated
Show resolved
Hide resolved
nkolev92
reviewed
Feb 25, 2021
nkolev92
reviewed
Feb 25, 2021
There was a problem hiding this comment.
We need to account for the case sensitivity and I think @kartheekp-ms has some good feedback as well.
src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs
Outdated
Show resolved
Hide resolved
nkolev92
approved these changes
Feb 25, 2021
erdembayar
reviewed
Feb 25, 2021
src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs
Show resolved
Hide resolved
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#6941
Regression? Last working version:
Description
This PR makes it so that pack fails if you try to pack two or more files into the exact same destination. We believe this is acceptable because, even though this would be a new error, the packages generated when this was happening are pretty much broken.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation