-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hook for disabling the default extensions in the build output #3980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Property Name suggestion...
src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.targets
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.targets
Outdated
Show resolved
Hide resolved
test/NuGet.Core.FuncTests/Dotnet.Integration.Test/PackCommandTests.cs
Outdated
Show resolved
Hide resolved
🔔 @Anipik |
i will try to get the tests in next week. |
@nkolev92 it seems like the ci is hung on this, do we need to do something ? |
@Anipik the CI for people without write access doesn't run automatically. Kicked it off. |
src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.targets
Outdated
Show resolved
Hide resolved
@nkolev92 do we need to trigger the ci again here ? |
@Anipik |
@erdembayar @nkolev92 the ci passed, can you merge it as well ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve it now, but wait little bit before merge, let other people review too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
hey @erdembayar @nkolev92 do we need something more here ? |
@Anipik |
awesome thanks. |
Fixes: NuGet/Home#10690
Description
This msbuild flag allows user to edit the default file extensions included in the build output of the package. eg. it allows us to exclude the .xml files from the package.
Test are added for validation
cc @ViktorHofer @ericstj