Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hook for disabling the default extensions in the build output #3980

Merged
merged 10 commits into from
May 24, 2021
Merged

add hook for disabling the default extensions in the build output #3980

merged 10 commits into from
May 24, 2021

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Apr 1, 2021

Fixes: NuGet/Home#10690

Description

This msbuild flag allows user to edit the default file extensions included in the build output of the package. eg. it allows us to exclude the .xml files from the package.

Test are added for validation

cc @ViktorHofer @ericstj

@Anipik Anipik requested a review from a team as a code owner April 1, 2021 23:22
Copy link
Contributor

@Nirmal4G Nirmal4G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property Name suggestion...

@zivkan zivkan added the Community PRs created by someone not in the NuGet team label Apr 5, 2021
@nkolev92
Copy link
Member

🔔 @Anipik

@Anipik
Copy link
Contributor Author

Anipik commented Apr 30, 2021

i will try to get the tests in next week.

@Anipik
Copy link
Contributor Author

Anipik commented May 19, 2021

@nkolev92 it seems like the ci is hung on this, do we need to do something ?

@nkolev92
Copy link
Member

@Anipik the CI for people without write access doesn't run automatically.

Kicked it off.

@nkolev92
Copy link
Member

@Anipik

There's some test failures. Can you access the following, check out the test table for partial results.

The tests that are failing are pack specific.

@Anipik
Copy link
Contributor Author

Anipik commented May 20, 2021

@nkolev92 do we need to trigger the ci again here ?

@erdembayar
Copy link
Contributor

@Anipik
I just trigged CI build. 🤞

@Anipik
Copy link
Contributor Author

Anipik commented May 22, 2021

@erdembayar @nkolev92 the ci passed, can you merge it as well ?

Copy link
Contributor

@erdembayar erdembayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it now, but wait little bit before merge, let other people review too.

Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Anipik
Copy link
Contributor Author

Anipik commented May 24, 2021

hey @erdembayar @nkolev92 do we need something more here ?

@erdembayar
Copy link
Contributor

hey @erdembayar @nkolev92 do we need something more here ?

@Anipik
Don't worry, I'll merge by lunch time if there is no one else comment.

@Anipik
Copy link
Contributor Author

Anipik commented May 24, 2021

awesome thanks.

@erdembayar erdembayar merged commit 25e7298 into NuGet:dev May 24, 2021
@Anipik Anipik deleted the extension branch May 24, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
6 participants