Add Analyzer packaging support and packaging documentation

[ericstj]

To package Microsoft.Extensions.Logging.Abstractions we needed support
for packing an Analyzer. This adds that support.

I wanted to document this addition, so I created the start of a doc that's
meant to describe the packaging options for libraries in dotnet/runtime.

Hopefully folks can pitch in and improve this doc.

[ghost]

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

---

To package Microsoft.Extensions.Logging.Abstractions we needed support
for packing an Analyzer. This adds that support.

I wanted to document this addition, so I created the start of a doc that's
meant to describe the packaging options for libraries in dotnet/runtime.

Hopefully folks can pitch in and improve this doc.

Author:	ericstj
Assignees:	-
Labels:	area-Extensions-Logging
Milestone:	-

[safern]

Thanks for writing such clear docs as well 🎉

[ViktorHofer]

With this changes we do have P2Ps in place which means we can remove the extra ProjectReferences in src.proj. Can you please remove these:

• runtime/src/libraries/src.proj

  Lines 10 to 11 in 7ecb1eb

  	<NonNetCoreAppProject Include="$(MSBuildThisFileDirectory)*\gen\*.csproj"
  	Exclude="@(ProjectExclusions)" />

• runtime/src/libraries/src.proj

  Lines 14 to 15 in 7ecb1eb

  	<NonNetCoreAppProject Include="$(MSBuildThisFileDirectory)*\gen\*.csproj"
  	Exclude="@(ProjectExclusions)" />

[ericstj]

With this changes we do have P2Ps in place which means we can remove the extra ProjectReferences in src.proj. Can you please remove these:

Actually I haven't moved System.Text.Json to csproj pack yet, so I think that's still needed. I'll see if I can make that work with only the CSProj change (not migrating to pkgproj yet).

[ericstj]

src\libraries\pkg\test\testPackages.proj(88,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Object reference not set to an instance of an object.

This is due to https://github.com/dotnet/arcade/blob/57707a9e0150de043f8fc4a849f1f4f47dd3219a/src/Microsoft.DotNet.PackageTesting/NupkgParser.cs#L60 returning null for assets outside lib/ref/runtimes. I think this will coincidentally be fixed by dotnet/arcade@5faea1b since that fixes the file filtering to include packageId.dll, right now it's using title.dll and title is empty so the analyzer dlls are being included.

[ericstj]

Failure is happening in Microsoft.Extensions.DependencyInjection.Specification.Tests

  Testing Microsoft.Extensions.DependencyInjection.Specification.Tests TFM=net462
C:\h\w\9EF60927\p\packageTest.targets(53,5): error : Assembly 'netfx.force.conflicts' has insufficient version for dependency 'System.ServiceModel.Duplex' : 4.0.0.0 < 4.0.2.0. [C:\h\w\9EF60927\w\AF2B09D2\u\net462\project.csproj]
  Testing Microsoft.Extensions.DependencyInjection.Specification.Tests TFM=net461
C:\h\w\9EF60927\p\packageTest.targets(53,5): error : Assembly 'netfx.force.conflicts' has insufficient version for dependency 'System.ServiceModel.Duplex' : 4.0.0.0 < 4.0.2.0. [C:\h\w\9EF60927\w\AF2B09D2\u\net461\project.csproj

This is saying that netfx.force.conflicts references version 4.0.2.0 of System.ServiceModel.Duplex yet the version provided is 4.0.0.0. This is due to System.ServiceModel.Duplex being produced OOB by WCF, but is not part of the package closure. netfx.force.conflicts is part of the netstandard support shims and contains a reference to the OOB version, yet the one in the product is lower.

[joperezr]

Minor Nit's but looks great otherwise, glad that we are moving away from pkgprojs 🙌

[ericstj]

glad that we are moving away from pkgprojs 🙌

Much thanks to @Anipik for making this possible

[ericstj]

Staging failures are #52736.