Use ProjectInstance.FromFile instead of Project.FromFile + Project.CreateInstance #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
nkolev92
previously approved these changes
Mar 16, 2022
jeffkl
previously approved these changes
Mar 16, 2022
dfederm
force-pushed
the
projectinstance-fromfile
branch
from
fa15f2e
to
502ac52
Compare
|
@nkolev92 please merge this. CLA bot isn't working and I messed up CI with a manual build but the real build passed just fine https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=5889397&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11675
Regression? Last working version:
Description
At the time Static Graph Restore was created, there was no
ProjectInstance.FromFileand no way to create aProjectInstancewith an evaluation context. This was fixed in dotnet/msbuild#5006. So now static graph restore can use that to avoid creating theProjectobject.This should be a perf improvement (admittedly minor).
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation