Add ability to supply an EvaluationContext to a directly created ProjectInstance #5006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfederm
force-pushed
the
dfederm/projectinstance-evalcontext
branch
from
56f8f44
to
6057552
Compare
cdmihai
suggested changes
Dec 30, 2019
There was a problem hiding this comment.
Looks good.
Can you add a test in ProjectEvaluationContext_Tests to assert that the shared context is indeed getting reused between multiple ProjectInstance evaluations? One way that comes to mind is to count the number of EvaluationContext instances that get created when instantiating multiple ProjectInstance objects. SharingPolicy.Shared should lead to having only one EvaluationContext instance, and SharingPolicy.Isolated should lead to the same number of EvaluationContext and ProjectInstance instances.
dfederm
force-pushed
the
dfederm/projectinstance-evalcontext
branch
from
6057552
to
30ce05f
Compare
cdmihai
approved these changes
Dec 30, 2019
rainersigwald
approved these changes
Jan 7, 2020
| /// <returns></returns> | ||
| public static ProjectInstance FromFile(string file, ProjectOptions options) | ||
| { | ||
| // string projectFile, IDictionary<string, string> globalProperties, string toolsVersion, string subToolsetVersion, ProjectCollection projectCollection, EvaluationContext evaluationContext |
There was a problem hiding this comment.
Lol oops. I had pasted this from the ctor I was targeting to get the right arguments in the right order since intellisense kept choosing the wrong one.
Forgind
pushed a commit
to Forgind/msbuild
that referenced
this pull request
Feb 3, 2020
…ectInstance (dotnet#5006) Add ability to supply an EvaluationContext to a directly created ProjectInstance
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.